Use Boolean.equals instead of == when comparing Boolean objects #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnou
approved these changes
Mar 18, 2020
dwnusbaum
commented
Mar 18, 2020
| FlowExecution fetchedExecution = getExecution(); // Triggers execution.onLoad so we can resume running if not done | ||
|
|
||
| if (fetchedExecution != null) { | ||
| if (completed == null) { | ||
| completed = Boolean.valueOf(fetchedExecution.isComplete()); | ||
| } | ||
|
|
||
| if (!completed == Boolean.TRUE) { | ||
| if (Boolean.FALSE.equals(completed)) { |
There was a problem hiding this comment.
Unrelated to the other changes. The old code was fine, since we check completed == null a few lines up and set it to a non-null value, but unnecessarily roundabout, since it was unboxing the Boolean to a boolean, then inverting that and comparing the inverted result to Boolean.TRUE, which was also unboxed into a boolean. Much clearer in my opinion to just compare to Boolean.FALSE directly.
car-roll
approved these changes
Mar 18, 2020
bitwiseman
approved these changes
Mar 18, 2020
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is safer to use
Boolean.equalsinstead of==when comparing nullableBooleanobjects in case one of the objects was constructed vianew Boolean(boolean), which creates distinct objects.I don't think that this code ever uses
new Boolean(boolean), but it doesn't hurt to make the code more robust just in case.