fix test #17
Merged
fix test #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maelle
commented
Oct 23, 2020
| @@ -76,7 +76,7 @@ testing_genetic <- dplyr::rename(testing_genetic, label = 1) | |||
| # testing_gene <- dplyr::rename(gene1, label = 1) | |||
|
|
|||
| test_that("data types correct before combining tree", { | |||
| expect_is(testing_tree, "tibble") | |||
| expect_is(testing_tree, "tbl_tree") | |||
There was a problem hiding this comment.
I was also seeing a failure for this hence this change.
|
@maelle thank you for pointing to the issue 'usual suspects' that is really helpful, I had not seen it before. |
|
you're welcome! it was a learning experience for me too! good luck with further development 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf https://community.rstudio.com/t/devtools-test-passes-but-devtools-check-fails/85555