Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add form field theming #17

Closed
wants to merge 10 commits into from
Closed

Add form field theming #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
404fd90
WIP label theming
jenny-s51 Sep 16, 2024
3e7c9e6
update border states to match MUI colors and styling when focused, la…
jenny-s51 Sep 17, 2024
bba7672
update form label color when field selected, add disabled styling
jenny-s51 Sep 18, 2024
dc18e5e
fix outline colors to match KF
jenny-s51 Sep 18, 2024
ac52b17
fieldset updates with mcoker, disabled state WIP
jenny-s51 Sep 19, 2024
71157d4
add conditionals for input fields when theme toggle is on
jenny-s51 Sep 20, 2024
7866ef4
feedback from mcoker, remove conditional rendering in favor of css class
jenny-s51 Sep 23, 2024
41d395d
Merge branch 'RHOAIENG-11806' into formTheming
jenny-s51 Sep 23, 2024
f98bbef
updates to form with mcoker
jenny-s51 Sep 26, 2024
1c5a298
format
jenny-s51 Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/app/HeaderTools.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@

React.useEffect(() => {
window.isSwitched = !isChecked;
}, [isChecked]);
}, [window.isSwitched]);

Check failure on line 46 in frontend/src/app/HeaderTools.tsx

View workflow job for this annotation

GitHub Actions / Tests (18.x) 

React Hook React.useEffect has a missing dependency: 'isChecked'. Either include it or remove the dependency array. Outer scope values like 'window.isSwitched' aren't valid dependencies because mutating them doesn't re-render the component

Check failure on line 46 in frontend/src/app/HeaderTools.tsx

View workflow job for this annotation

GitHub Actions / Tests (18.x) 

React Hook React.useEffect has a missing dependency: 'isChecked'. Either include it or remove the dependency array. Outer scope values like 'window.isSwitched' aren't valid dependencies because mutating them doesn't re-render the component

const handleChange = (_event: React.FormEvent<HTMLInputElement>, checked: boolean) => {
setIsChecked(!checked);
Expand Down
Loading
Loading