Skip to content

Commit

Permalink
Implemented that inactive programs get gray text to make them more ea…
Browse files Browse the repository at this point in the history
…sier distinguishable. This closes  #779.
  • Loading branch information
jp112sdl authored Feb 27, 2020
1 parent 901c77d commit 2a92422
Show file tree
Hide file tree
Showing 5 changed files with 19,040 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
--- occu/WebUI/www/rega/pages/tabs/admin/views/programlist.htm.orig
+++ occu/WebUI/www/rega/pages/tabs/admin/views/programlist.htm
@@ -122,20 +122,21 @@
{
string trId = "program"#o.ID();
WriteLine( '<tr id="'#trId#'" class="CLASS04901">' );
- WriteLine( '<td class="tBodyCell">'#o.Name()#'</td>' );
- WriteLine( '<td class="tBodyCell">'#o.PrgInfo()#'</td>' );
- WriteLine( '<td class="tBodyCell">' );
+ string sInactive = ""; if( !o.Active() ) { sInactive = "Inactive"; }
+ WriteLine( '<td class="tBodyCell'#sInactive#'">'#o.Name()#'</td>' );
+ WriteLine( '<td class="tBodyCell'#sInactive#'">'#o.PrgInfo()#'</td>' );
+ WriteLine( '<td class="tBodyCell'#sInactive#'">' );
object oPrgID = o.ID();
string sRet = "";
Call( "/esp/programs.fn::WriteConditionText()" );
Write (sRet);
WriteLine( '</td>' );
- WriteLine( '<td class="tBodyCell">' );
+ WriteLine( '<td class="tBodyCell'#sInactive#'">' );
string sRet = "";
Call( "/esp/programs.fn::WriteDestinationText()" );
Write(sRet);
WriteLine( '</td>' );
- WriteLine( '<td class="tBodyCell CLASS04902" >' );
+ WriteLine( '<td class="tBodyCell'#sInactive#' CLASS04902" >' );
WriteLine( '<table cellpadding="0" cellspacing="0" border="0">' );
WriteLine( '<tr>' );
WriteLine( '<td>' );
@@ -215,16 +216,17 @@
if( (o.IsTypeOf( OT_PROGRAM )) && (o.ProgramCopyID()==ID_ERROR) )
{
string trId = "program"#o.ID();
+ string sInactive = ""; if( !o.Active() ) { sInactive = "Inactive"; }
WriteLine( '<tr id="'#trId#'" class="CLASS04901">' );
- WriteLine( '<td class="tBodyCell">'#o.Name()#'</td>' );
- WriteLine( '<td class="tBodyCell">'#o.PrgInfo()#'</td>' );
- WriteLine( '<td class="tBodyCell">' );
+ WriteLine( '<td class="tBodyCell'#sInactive#'">'#o.Name()#'</td>' );
+ WriteLine( '<td class="tBodyCell'#sInactive#'">'#o.PrgInfo()#'</td>' );
+ WriteLine( '<td class="tBodyCell'#sInactive#'">' );
object oPrgID = o.ID();
string sRet = "";
Call( "/esp/programs.fn::WriteConditionText()" );
Write (sRet);
WriteLine( '</td>' );
- WriteLine( '<td class="tBodyCell">' );
+ WriteLine( '<td class="tBodyCell'#sInactive#'">' );
string sRet = "";
Call( "/esp/programs.fn::WriteDestinationText()" );
Write(sRet);
--- occu/WebUI/www/webui/style.css.orig
+++ occu/WebUI/www/webui/style.css
@@ -1201,6 +1201,16 @@
text-align: left;
}

+.tBodyCellInactive
+{
+ background-color: $_(activeBackground); /* #f0f0f0 */
+ height: 40px;
+ border: solid 1px $_(black); /* black */
+ color: $_(inactiveBackground); /* #bcc7cb */
+ padding: 4px;
+ text-align: left;
+}
+
.tBodyCellCenter
{
background-color: $_(activeBackground); /* #f0f0f0 */
Loading

1 comment on commit 2a92422

@drose28357
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Da ich mich gerade in einem Projekt mit Barrierefreiheit im UI beschäftige (und schon über 60 bin)...

  1. ist bei dieser Lösung die Kontrastdifferenz zwischen Vordergrund und Hintergrund bei Schriftfarbe Grau zu gering
  2. für Farbenblinde sollte unterschiedliche Symbole angezeigt werden, die man auch dann unterscheiden kann, wenn alles nur schwarzweiß wahrgenommen wird.

Diesen Kommentar bitte als Hinweis für zukünftige Änderungen verstehen ....

Please sign in to comment.