Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0177-WebUI-Fix-MissingHmIPButtonActionTranslations.patch #2222

Merged
merged 2 commits into from
Feb 18, 2023

Conversation

Baxxy13
Copy link
Contributor

@Baxxy13 Baxxy13 commented Feb 18, 2023

Description

Fixes the missing german translations for (relatively new) HmIP "button press long" actions

  • PRESS_LONG_START
  • PRESS_LONG_RELEASE

Examples:
System-Protocol Output before:
16:57:16 13.02.2023 HmIP-MOD-RC8 7F9:1 - Taster 1 Tastendruck lang, unbekannte Meldung (PRESS_LONG_START=TRUE), Tastendruck lang

System-Protocol Output after:
17:17:33 13.02.2023 HmIP-MOD-RC8 7F9:1 - Taster 1 Tastendruck lang, Start langer Tastendruck, Tastendruck lang

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Alternate Designs

Possible Drawbacks

Not known. I can't see any side effects during testing.

Verification Process

Executed this patch on 3 different test-systems and checked the result. No problems found.

Release Notes

This fixes an issue that german translations for the HmIP-Button-Actions PRESS_LONG_START / PRESS_LONG_RELEASE are not shown in e.g. the system-protocol.

Contributing checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING and LICENSE document.
  • I fully agree to distribute my changes under Apache 2.0 license.

Fixes the missing german translations for new long button press actions
- PRESS_LONG_START
- PRESS_LONG_RELEASE
@jens-maus
Copy link
Owner

Instead of creating a new WebUI Patch for fixing missing translations please integrate it in the already existing one. There should be one named something like "FixingTranslation".

@Baxxy13
Copy link
Contributor Author

Baxxy13 commented Feb 18, 2023

Ist das kompliziert...
Hoffe so war das richtig.

@jens-maus jens-maus added 🐛 bug-report Something isn't working 🏷️ WebUI This refs the WebUI component labels Feb 18, 2023
@jens-maus jens-maus added this to the next release milestone Feb 18, 2023
@jens-maus jens-maus merged commit b802d61 into jens-maus:master Feb 18, 2023
@Baxxy13 Baxxy13 deleted the FixMissingButtonActionTranslation branch February 19, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug-report Something isn't working 🏷️ WebUI This refs the WebUI component
Projects
Development

Successfully merging this pull request may close these issues.

2 participants