Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhanced all SXX init scripts which can execute an rc.xxx file #2450

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

Baxxy13
Copy link
Contributor

@Baxxy13 Baxxy13 commented Sep 27, 2023

Description

  • added timeout 120 to execute command, eg: timeout 120 /usr/local/etc/rc.local
  • added echo output if rc.xxx file exists and is executable, eg: echo -n "rc.local, "

Related Issue

#2448 (comment)

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Alternate Designs

Possible Drawbacks

If the user uses all 5 rc.xxx with functions that never ends, bootime will be increase for at least 10 Minutes.

Verification Process

Implemented this change on my RaspberryMatic Testsystem and booted multiple times.
Output looks fine (all 5 rc.xxx are available), but i don't tested the timeouts yet.

fsck 1.47.0 (5-Feb-2023)
userfs: clean, 547/704512 files, 204089/2817792 blocks
Starting watchdog...
Identifying host system: ova-KVM, OK
Initializing ZRAM Swap: OK
Initializing RTC Clock: onboard, OK
Starting acpid: OK
Running sysctl: OK
Running seedrng: OK
Checking for Factory Reset: not required
Checking for Backup Restore: not required
Initializing System: rc.init, rc.postinit, OK
Setup ca-certificates: OK
Starting logging: OK
Populating /dev using udev: done
Init onboard LEDs: init, OK
Starting qemu-guest-agent: OK
Starting irqbalance: OK
Starting system message bus: done
Starting iptables: OK
Starting bluetoothd: disabled
Starting network: eth0: link up, dhcp, firewall, inet up, 192.168.113.96, wlan0: missing, OK
Starting Network Interface Plugging Daemon: eth0.
Starting chrony: OK
Identifying Homematic RF-Hardware: ....HmRF: HMIP-RFUSB/eQ-3 HmIP-RFUSB@usb-0000:02:1b.0-1, HmIP: HMIP-RFUSB/eQ-3 HmIP-RFUSB@usb-0000:02:1b.0-1, OK
Updating Homematic RF-Hardware: HMIP-RFUSB: 4.4.18, not necessary, OK
Starting hs485dLoader: disabled
Starting xinetd: OK
Starting eq3configd: OK
Starting lighttpd: OK
Starting ser2net: disabled
Starting ssdpd: OK
Starting sshd: OK
Starting NUT services: disabled
Initializing Third-Party Addons: rc.prelocal, OK
Starting LGWFirmwareUpdate: ...OK
Setting LAN Gateway keys: OK
Starting SNMP daemon: OK
Starting hs485d: disabled
Starting multimacd: ...OK
Starting rfd: .OK
Starting HMIPServer: .........OK
Starting ReGaHss: .OK
Starting CloudMatic: disabled
Starting Third-Party Addons: rc.local, OK
Starting crond: OK
Setup onboard LEDs: rc.postlocal, booted, OK
Finished Boot: 3.71.12.20230927 (raspmatic_ova)

Release Notes

Added timeout and echo output to all SXX init scripts which can execute rc.xxx files.

Contributing checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING and LICENSE document.
  • I fully agree to distribute my changes under Apache 2.0 license.

Baxxy13 and others added 2 commits September 27, 2023 13:37
- added timeout 100 to execute
- added echo output when rx.xx file exists and is executable
@jens-maus jens-maus added the 💡 enhancement-ideas New feature or change request label Sep 27, 2023
@jens-maus jens-maus added this to the next release milestone Sep 27, 2023
@jens-maus jens-maus merged commit 7786ab5 into jens-maus:master Sep 27, 2023
5 checks passed
@Baxxy13 Baxxy13 deleted the enhance_sxx_init_scrips branch October 10, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 enhancement-ideas New feature or change request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants