Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust adapter gem versions to required versions in Rails #74

Merged
merged 1 commit into from
Aug 8, 2018

Conversation

barthez
Copy link
Contributor

@barthez barthez commented Jul 27, 2018

It was impossible to run tests on Travis CI due too loose requirements on gem versions. Bundler was loading version too new for specific Rails version.

I have copied required versions from active_record/connection_adapters/* for each adapter*.


(*) There was an issue with mysql2 0.4.3 and Rails 5.x so I kept ~> 0.4.4 version constraint.

@barthez
Copy link
Contributor Author

barthez commented Aug 2, 2018

Hey @jenseng,

Is there any chance you could merge this PR and #72 and then release new version of a gem?

@DNNX DNNX mentioned this pull request Aug 6, 2018
It was impossible to run tests on Travis CI due too lose requirements
on gem versions. Bundler was loading version too new for specific
Rails version.
@jenseng
Copy link
Owner

jenseng commented Aug 8, 2018

Looks good, thanks for this! 👍

@jenseng jenseng merged commit 8840ecf into jenseng:master Aug 8, 2018
@jenseng
Copy link
Owner

jenseng commented Aug 8, 2018

v0.2.21 has been released with these fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants