Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ruby 2.7 warnings on Proc.new #90

Merged
merged 1 commit into from
Jan 31, 2021
Merged

Conversation

erikaxel
Copy link
Contributor

@erikaxel erikaxel commented Mar 12, 2020

This fixes issue #89 Ruby 2.7 gives warning on use of Proc.new:
hair_trigger/builder.rb:145: warning: Capturing the given block using Proc.new is deprecated; use &blockinstead hair_trigger/builder.rb:155: warning: Capturing the given block using Proc.new is deprecated; use&block instead

@liaden
Copy link

liaden commented Mar 16, 2020

Referenced this in my Gemfile and ran tests. Warnings are gone and my tests stayed green.

@adrijere
Copy link

Same here, all green, thanks for the job done ✌️

@manuelmeurer
Copy link

@jenseng Could you merge this and release a new version please? Thanks! 🙇

@adrijere
Copy link

Any update @jenseng :) ?

@hrs113355
Copy link

@jenseng It would be great to have this in a new version 🙏

@Laykou
Copy link

Laykou commented Jan 20, 2021

Calling Proc.new without block is not working in Ruby 3.0.

Error:

StandardError: An error has occurred, all later migrations canceled:

tried to create Proc object without a block

@jenseng Could you please merge this and release as a new version? Thank you!

@Laykou
Copy link

Laykou commented Jan 26, 2021

Hi guys, I see @jenseng is not responding and last commit in master is since Sep 2019. Do you think this repo is abandoned and we should do our own fork? It's unfortunate, since it looked like a solid gem :'(

@jenseng
Copy link
Owner

jenseng commented Jan 31, 2021

👋 sorry everyone, my github notifications were off and I haven't been using this gem (or even ruby) in years 😬 ... I'll get these merged and released shortly, but if anyone wants to help take over maintaining this gem moving forward I'm totally open to it 🤗

@jenseng jenseng merged commit 58ea4c1 into jenseng:master Jan 31, 2021
@jenseng jenseng mentioned this pull request Jan 31, 2021
@jenseng
Copy link
Owner

jenseng commented Feb 1, 2021

released in v0.2.24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants