RN: Silently Fail onRequestPermissionsResult for Invalid Activities (…

…facebook#37047)

Summary:
Pull Request resolved: facebook#37047

We're seeing scenarios where `onRequestPermissionsResult` is being invoked but the current activity does not implement `PermissionAwareActivity`. This should not crash the app.

Changelog:
[Android][Fixed] - Fix crash when Android requests permission with activity that does not implement `PermissionAwareActivity`

Reviewed By: mdvacca

Differential Revision: D45203319

fbshipit-source-id: 4a6eb67ad67ae5c731c27301967b837b1286ccbb

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/permissions/PermissionsModule.java

@@ -13,6 +13,7 @@
 import android.os.Build;
 import android.os.Process;
 import android.util.SparseArray;
+import com.facebook.common.logging.FLog;
 import com.facebook.fbreact.specs.NativePermissionsAndroidSpec;
 import com.facebook.react.bridge.Callback;
 import com.facebook.react.bridge.Promise;
@@ -198,9 +199,17 @@ public void invoke(Object... args) {
   @Override
   public boolean onRequestPermissionsResult(
       int requestCode, String[] permissions, int[] grantResults) {
-    mCallbacks.get(requestCode).invoke(grantResults, getPermissionAwareActivity());
-    mCallbacks.remove(requestCode);
-    return mCallbacks.size() == 0;
+    try {
+      mCallbacks.get(requestCode).invoke(grantResults, getPermissionAwareActivity());
+      mCallbacks.remove(requestCode);
+      return mCallbacks.size() == 0;
+    } catch (IllegalStateException e) {
+      FLog.e(
+          "PermissionsModule",
+          e,
+          "Unexpected invocation of `onRequestPermissionsResult` with invalid current activity");
+      return false;
+    }
   }
 
   private PermissionAwareActivity getPermissionAwareActivity() {