Skip to content

Commit

Permalink
DevTools: fix backend activation (facebook#26779)
Browse files Browse the repository at this point in the history
Summary:
## Summary
We have a case:
1. Open components tab
2. Close Chrome / Firefox devtools window completely
3. Reopen browser devtools panel
4. Open components tab

Currently, in version 4.27.6, we cannot load the components tree.

This PR contains two changes:
- non-functional refactoring in
`react-devtools-shared/src/devtools/store.js`: removed some redundant
type castings.
- fixed backend manager logic (introduced in
facebook/react#26615) to activate already
registered backends. Looks like frontend of devtools also depends on
`renderer-attached` event, without it component tree won't load.

## How did you test this change?
This fixes the case mentioned prior. Currently in 4.27.6 version it is
not working, we need to refresh the page to make it work.

I've tested this in several environments: chrome, firefox, standalone
with RN application.

DiffTrain build for commit facebook/react@377c517.

Changelog: [Internal]
<< DO NOT EDIT BELOW THIS LINE >>

Reviewed By: sammy-SC

Differential Revision: D45573294

Pulled By: tyao1

fbshipit-source-id: 42a8e4a54cd367080fdb7e1c357c48ae3564b7f0
  • Loading branch information
hoxyq authored and jeongshin committed May 7, 2023
1 parent e668866 commit d792ba0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/react-native/Libraries/Renderer/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
aef7ce5547c9489dc48e31f69b002cd17206e0cb
377c5175f78e47a3f01d323ad6528a696c88b76e

0 comments on commit d792ba0

Please sign in to comment.