Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement more tests and functionality #5

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

jerbob92
Copy link
Owner

@jerbob92 jerbob92 commented Sep 28, 2023

Add even more tests and implement:

  • create_inheriting_constructor
  • emval_equals
  • emval_strictly_equals
  • emval_set_property and emval_get_property for slices and maps

@codecov-commenter
Copy link

Codecov Report

Merging #5 (4e4a3a5) into main (0038b1c) will decrease coverage by 0.02%.
Report is 2 commits behind head on main.
The diff coverage is 64.70%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
- Coverage   72.47%   72.46%   -0.02%     
==========================================
  Files          21       21              
  Lines        4491     4667     +176     
==========================================
+ Hits         3255     3382     +127     
- Misses        876      905      +29     
- Partials      360      380      +20     
Files Coverage Δ
internal/engine.go 70.80% <50.00%> (-0.88%) ⬇️
internal/class.go 78.31% <71.83%> (-0.33%) ⬇️
internal/emval.go 60.50% <62.66%> (+0.78%) ⬆️

... and 1 file with indirect coverage changes

@jerbob92 jerbob92 changed the title Feature/implement more tests Implement more tests and functionality Sep 28, 2023
@jerbob92 jerbob92 merged commit b0029cd into main Sep 28, 2023
12 of 14 checks passed
@jerbob92 jerbob92 deleted the feature/implement-more-tests branch April 17, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants