Modalize doesn't clear hardwareBackPress at component unmount #111
Labels
🤕 Valid issue
Something isn't working
Comments
|
Hi, I didn't think about this behaviour, since Modalize is always there in my apps/examples. You could provide a PR if you have a fix, it shouldn't be complicated, |
|
I second that. It is actually a bug.Thank you in advance |
Grohden
added a commit
to Grohden/react-native-modalize
that referenced
this issue
Feb 17, 2020
This should fix the jeremybarbet#111, where one could do: `cond ? <Modalize ...> : null`, and a `cond=false` could cause the modalize to keep listening to back press events
|
@jeremybarbet @itsam I was using a patch package patch for this, so I wasn't in a hurry for it. But anyway #137 should fix the problem. |
|
@Grohden Thanks a lot. |
jeremybarbet
pushed a commit
that referenced
this issue
Feb 18, 2020
This should fix the #111, where one could do: `cond ? <Modalize ...> : null`, and a `cond=false` could cause the modalize to keep listening to back press events
|
Fixed by @Grohden and released in |
marcinolek
pushed a commit
to marcinolek/react-native-modalize
that referenced
this issue
Feb 20, 2020
This should fix the jeremybarbet#111, where one could do: `cond ? <Modalize ...> : null`, and a `cond=false` could cause the modalize to keep listening to back press events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#35 related
Looking at this commit, it seems that the remove listener call was moved to the closeAnimation, but removing it from the
componentWillUnmountwill make the listener always be active when only a unmount occur (such as something bad likecond ? null : <Modalize .../>)The text was updated successfully, but these errors were encountered: