Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hardware back button press handler #148

Merged
merged 1 commit into from
Mar 17, 2020
Merged

Fix hardware back button press handler #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,15 +505,15 @@ export class Modalize<FlatListItem = any, SectionListItem = any> extends React.C
}
};

private onBackPress = async (): Promise<boolean> => {
private onBackPress = (): boolean => {
const { onBackButtonPress, alwaysOpen } = this.props;

if (alwaysOpen) {
return false;
}

if (onBackButtonPress) {
onBackButtonPress();
return onBackButtonPress();
} else {
this.close();
}
Expand Down
2 changes: 1 addition & 1 deletion src/options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ export interface IProps<FlatListItem = any, SectionListItem = any> {
* Android or the menu button on Apple TV. You can any function you want,
* but you will have to close the modal by yourself.
*/
onBackButtonPress?: () => void;
onBackButtonPress?: () => boolean;

/**
* Callback function which determines if the modal has reached the top
Expand Down