Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow for HTTP auth settings for Retire JS respository #5209

Merged
merged 2 commits into from
Jan 8, 2023
Merged

feat: Allow for HTTP auth settings for Retire JS respository #5209

merged 2 commits into from
Jan 8, 2023

Conversation

emeric-martineau
Copy link
Contributor

@emeric-martineau emeric-martineau commented Jan 4, 2023

Fixes Issue

Fix #5195

Description of Change

Allow add user/password to download RetriveJS

Have test cases been added to cover the new functionality?

no

@boring-cyborg boring-cyborg bot added ant changes to ant cli changes to the cli core changes to core maven changes to the maven plugin tests test cases utils changes to utils labels Jan 4, 2023
@emeric-martineau emeric-martineau marked this pull request as draft January 4, 2023 16:18
@boring-cyborg boring-cyborg bot added the documentation site documentation label Jan 5, 2023
@emeric-martineau emeric-martineau changed the title [WIP] Allow for HTTP auth settings for Retire JS respository Allow for HTTP auth settings for Retire JS respository Jan 5, 2023
@emeric-martineau emeric-martineau marked this pull request as ready for review January 5, 2023 13:36
@emeric-martineau emeric-martineau changed the title Allow for HTTP auth settings for Retire JS respository feat: Allow for HTTP auth settings for Retire JS respository Jan 5, 2023
@aikebah aikebah added this to the 8.0.0 milestone Jan 8, 2023
@aikebah aikebah merged commit 175a00d into jeremylong:main Jan 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ant changes to ant cli changes to the cli core changes to core documentation site documentation maven changes to the maven plugin tests test cases utils changes to utils
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI: Allow for HTTP auth settings for Retire JS respository
3 participants