feat: support Pipenv - Pipfile.lock #5404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for Pipefile.lock per #4995
boring-cyborg
bot
added
ant
|
Looks like autocorrect messed up your PR message (pipefile / pipelock / bother) Code looks good to me. One remark: I think it would be good to add some remark in the javadoc of both analyzers that they operate in tandem on the same activation property (with the new analyzer taking over when a lock file is present), so that when revisiting them in the future it's hinted by the docs that if one changes the other is likely to need change as well. |
jeremylong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Pipfile.lock per #4995.
This currently uses the exact same enable/disable settings as the PipfileAnalyzer - and will supersede the PipfileAnalyzer if bother a
PipfileandPipfile.lockexist.