Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enables oppening user profile from user menu in iframe tab #1246

Merged
merged 1 commit into from
Feb 5, 2024
Merged

feat: Enables oppening user profile from user menu in iframe tab #1246

merged 1 commit into from
Feb 5, 2024

Conversation

ruanpepe
Copy link
Contributor

@ruanpepe ruanpepe commented Feb 5, 2024

Question Answer
Issue or Enhancement Enhancement
License MIT

What's in this PR?

It changes the user menu profile button target when in iFrame mode. With this changes, the profile page will open as a new tab.

Checklist

  • I tested these changes.
  • I have linked the related issues.

@dfsmania dfsmania self-requested a review February 5, 2024 16:35
@ruanpepe ruanpepe requested a review from dfsmania February 5, 2024 18:30
@dfsmania dfsmania requested a review from resslinger February 5, 2024 19:22
@resslinger resslinger merged commit 6f77753 into jeroennoten:master Feb 5, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants