Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to return the AR Controller Instance #666

Merged
merged 1 commit into from
Dec 22, 2019

Conversation

JoshuaAHill
Copy link
Contributor

the AR Controller Instance allows prototype commands to be called from outside of the aframe-ar.js class

⚠️ All PRs have to be done versus 'dev' branch, so be aware of that, or we'll close your issue ⚠️

What kind of change does this PR introduce?

New Feature

Can it be referenced to an Issue? If so what is the issue # ?
Getting Marker Locations - #636

How can we test it?

Used to get the quantity and position of the markers using:
var ARController = getARController();
var numMarkers = ARController.getMarkerNum();
var i;
for(i = 0 ; i< arController.getMarkerNum() ; i++){
console.log(arController.getMarker(i).pos);
}

Summary

Exposed Object so methods can be called from client - means we can get marker information out of Aframe and into our own program i.e the position thats being used to place the 3D overlay to changing the marker tracking type (colpour, mono) and more.

Does this PR introduce a breaking change?
Not that im aware of - perhaps saftey issyes?

Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser

Firefox 70.0.1 + laptop i5 7200U + windows 10 home

Other information

the AR Controller Instance allows prototype commands to be called from outside of the aframe-ar.js class
@nicolocarpignoli
Copy link
Collaborator

Hi
please, provide also modified files on src.

You have committed only the builded file.

You should modify files on source code. Then run 'make minify' and then commit and push everything.

We should see on this PR source code modified + aframe-ar.js + aframe-ar.min.js

@nicolocarpignoli nicolocarpignoli merged commit 48e197b into jeromeetienne:dev Dec 22, 2019
nicolocarpignoli added a commit that referenced this pull request Feb 3, 2020
Added ability to return the AR Controller Instance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants