Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in HttpApiClient #2

Merged
merged 2 commits into from
Apr 15, 2021
Merged

Fix typo in HttpApiClient #2

merged 2 commits into from
Apr 15, 2021

Conversation

LordSimal
Copy link
Contributor

apiHost was not working because of this small typo 😉

@LordSimal
Fix typo in HttpApiClient
57d4798 
apiHost was not working because of this small typo 😉
@jeromegamez
Copy link
Owner

Huch! Thank you! Could you please add a curly brace instead of removing it? Just so it's the same interpolation everywhere 😅

@jeromegamez
Copy link
Owner

Note to self: add proper tests 😅

@LordSimal
Copy link
Contributor Author

There you go 😄

@jeromegamez jeromegamez merged commit c5f241c into jeromegamez:main Apr 15, 2021
@jeromegamez
Copy link
Owner

Thank you! 🌺

@jeromegamez
Copy link
Owner

Aaaaand here's the release: 2.0.1

@LordSimal LordSimal deleted the patch-1 branch November 25, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LordSimal @jeromegamez