Fixes msvc warnings #4862
Closed
Fixes msvc warnings #4862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the code a bit by rename lit_unicode_white_space_interval_lengths to lit_unicode_white_space_interval_ends [build] [1/3 33% :: 0.150] Building C object jerry-core\CMakeFiles\jerry-core.dir\lit\lit-char-helpers.c.obj [build] C:\work\study\languages\typescript\jerryscript\jerry-core\lit\lit-char-helpers.c(154): warning C4018: '<=': signed/unsigned mismatch JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
rerobika
requested changes
Dec 8, 2021
| */ | ||
| static const uint8_t lit_unicode_white_space_interval_lengths[] JERRY_ATTR_CONST_DATA = { 0x000a }; | ||
| static const uint16_t lit_unicode_white_space_interval_ends[] JERRY_ATTR_CONST_DATA = { 0x2000 + 0x000a }; |
There was a problem hiding this comment.
That's an auto generated file, so no way that you can edit it like that.
| @@ -150,8 +150,7 @@ lit_char_is_white_space (lit_code_point_t c) /**< code point */ | |||
| } | |||
|
|
|||
| return (c <= LIT_UTF16_CODE_UNIT_MAX | |||
| && ((c >= lit_unicode_white_space_interval_starts[0] | |||
| && c <= lit_unicode_white_space_interval_starts[0] + lit_unicode_white_space_interval_lengths[0]) | |||
| && ((c >= lit_unicode_white_space_interval_starts[0] && c <= lit_unicode_white_space_interval_ends[0]) | |||
There was a problem hiding this comment.
lit_unicode_white_space_interval_starts[0] is an u16,
lit_unicode_white_space_interval_lengths[0] is an u16,
their sum is an int, so a simple cast to lit_code_point_t should resolve this warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the code a bit by rename lit_unicode_white_space_interval_lengths to lit_unicode_white_space_interval_ends
[build] [1/3 33% :: 0.150] Building C object jerry-core\CMakeFiles\jerry-core.dir\lit\lit-char-helpers.c.obj
[build] C:\work\study\languages\typescript\jerryscript\jerry-core\lit\lit-char-helpers.c(154): warning C4018: '<=': signed/unsigned mismatch
JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com