-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update doxygen #5106
Update doxygen #5106
Conversation
6e283fe
to
72d8816
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/** \addtogroup ecma ECMA | ||
* @{ | ||
* | ||
* \addtogroup ecmabuiltinhelpers ECMA builtin helper operations | ||
* @{ | ||
*/ | ||
|
||
#if JERRY_BUILTIN_JSON | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel this change (or these changes) somewhat arbitrary. There are lots of such C files, e.g., in the builtin-objects directory, that use the #if-@{-@}-#endif
structure. This file used the #if-@{-#endif-@}
pattern, which of course needs to be fixed, but I am not sure whether the @{-#if-#endif-@}
structure is the way to go. But if we go that way, we should apply it consistently throughout the whole codebase.
Update Doxyfile to version 1.9.1 Re-enable doxygen CI checker Fix some regular comments that should have been doc comments Document void return types for some inline functions explicitly Move start of some doxygen groups so they are included always, and not left out of certain ifdefs Ignore some doxygen warnings: Member (function) is not documented in headers Documented empty return type in headers Argument has multiple @param documentation sections JerryScript-DCO-1.0-Signed-off-by: Máté Tokodi mate.tokodi@szteszoftver.hu
72d8816
to
5562ab9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This patch depends on #5096
In this patch: