Update clang-format #5112
Merged
Update clang-format #5112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zherczeg
requested changes
Dec 4, 2023
| @@ -262,7 +262,7 @@ typedef ecma_value_t (*ecma_builtin_helper_sort_compare_fn_t) (ecma_value_t lhs, | |||
| ecma_value_t rhs, /**< right value */ | |||
| ecma_value_t compare_func, /**< compare function */ | |||
| ecma_object_t *array_buffer_p /**< arrayBuffer */ | |||
| ); | |||
| ); | |||
There was a problem hiding this comment.
Should be
ecma_object_t *array_buffer_p); /**< arrayBuffer */
There was a problem hiding this comment.
It cannot be ecma_object_t *array_buffer_p); /**< arrayBuffer */ bacause doxygen will complain that array_buffer_p is not documented, because the comment is outside the parentheses. However ecma_object_t *array_buffer_p /**< arrayBuffer */); is will work.
| prop_desc_p->flags = (uint16_t) ( | ||
| prop_desc_p->flags | (ecma_is_property_writable (property) ? JERRY_PROP_IS_WRITABLE : JERRY_PROP_NO_OPTS)); | ||
| prop_desc_p->flags = | ||
| (uint16_t) (prop_desc_p->flags |
There was a problem hiding this comment.
Do we need the (prop_desc_p->flags part?
There was a problem hiding this comment.
I do not believe so, it can fit into one |= expression.
matetokodi
force-pushed
the
update_clangformat
branch
from
8daa995 to
3aa18e2
Compare
matetokodi
force-pushed
the
update_clangformat
branch
from
3aa18e2 to
b08fbe9
Compare
Bump minimum clang-format version to 15 (the previously used 10 is not in the ubuntu-22.04 repo) Reformat several files Re-enable format and strings CI checkers JerryScript-DCO-1.0-Signed-off-by: Máté Tokodi mate.tokodi@szteszoftver.hu
matetokodi
force-pushed
the
update_clangformat
branch
from
b08fbe9 to
fca79e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this patch: