Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run doctest code snippets instead of compiling them, where possible. #5193

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Run doctest code snippets instead of compiling them, where possible. #5193

merged 1 commit into from
Dec 17, 2024

Conversation

lygstate
Copy link
Contributor

@lygstate lygstate commented Dec 9, 2024

Code have main entrypoint should be run or 'link', not 'compile'

JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com

@lygstate
docs: Fixes test code
9b8f879 
JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
@LaszloLango LaszloLango added the documentation Related to documentation label Dec 11, 2024
@LaszloLango LaszloLango changed the title docs: Fixes test code Run doctest code snippets instead of compiling where possible. Dec 11, 2024
@LaszloLango LaszloLango changed the title Run doctest code snippets instead of compiling where possible. Run doctest code snippets instead of compiling them, where possible. Dec 11, 2024
LaszloLango
LaszloLango approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaszloLango LaszloLango added this to the Release 3.0.0 milestone Dec 11, 2024
robertsipka
robertsipka approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@robertsipka robertsipka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsipka robertsipka merged commit 77c72d4 into jerryscript-project:master Dec 17, 2024
26 checks passed
@lygstate lygstate deleted the ext-doc-fixes-main branch December 17, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaszloLango LaszloLango LaszloLango approved these changes

@robertsipka robertsipka robertsipka approved these changes

Assignees
No one assigned
Labels
documentation Related to documentation
Projects
None yet
Milestone
Release 3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lygstate @robertsipka @LaszloLango