Fixes deadloop when abort is called in CI #5197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable the debug popup on MSVC/win32 by introduce new jerry_port_init function For not popup dialog when crash happend on MSVC/win32 Closed: jerryscript-project#4463 JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
lygstate
force-pushed
the
disable-win32-crash-popup
branch
from
957d7db to
c55fed8
Compare
|
#4856 want this, otherwise win32 CI will easily trigger deadloop issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable the debug popup on MSVC/win32 by introduce new jerry_port_init function
For not popup dialog when crash happend on MSVC/win32 Closed: #4463
This is a broadly way to handle abort on CI
such as:
https://github.com/pgspider/pgspider/blob/f33c26e402bd3774a9dc3bfb7476b90afc384344/src/backend/main/main.c#L267
Search
SetErrorModein github also found many other examplesJerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com