Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spago.lock format changed to JSON #3

Closed
jamesdbrock opened this issue Oct 16, 2024 · 5 comments
Closed

spago.lock format changed to JSON #3

jamesdbrock opened this issue Oct 16, 2024 · 5 comments
Assignees
@jeslie0

Comments

@jamesdbrock
Copy link

mkSpagoDerivation/nix/buildFromLockFile.nix

Line 5 in beeac0a

fromYAML (builtins.readFile spagoLockFile);

purescript/spago#1280
@jamesdbrock
Copy link
Author

Fabrizio said on the Discord today that “the format for the spago.lock is likely to change one more time before we call it stable.”

@jamesdbrock
Copy link
Author

This looks like a really nice project @jeslie0 , good work.

@jeslie0
Copy link
Owner

jeslie0 commented Oct 16, 2024

Thank you for filing this issue! I will have a look at the changes to the lock file when I have some free time.

jeslie0 added a commit that referenced this issue Oct 20, 2024
@jeslie0
Update project to use Spago's JSON lock files, not YAML
84f7696 
This should close [#3].
@jeslie0
Copy link
Owner

jeslie0 commented Oct 20, 2024

Okay, I am happy to say that this has been done. I decided against keeping support for the YAML based lock files as Spago seems to change all lock files to JSON whenever it is invoked now.

@jeslie0 jeslie0 closed this as completed Oct 20, 2024
@jeslie0 jeslie0 self-assigned this Oct 20, 2024
@jamesdbrock
Copy link
Author

Sweet, thanks man.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeslie0 jeslie0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamesdbrock @jeslie0