Change the API to support filesystem::path if this feature is available #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitri-tdg
changed the title
dimitri-tdg
changed the title
jessey-git
reviewed
Aug 15, 2021
|
@dimitri-tdg Wow, thanks for doing this work! I think this looks fine as-is with 1 minor comment that I left relating to undefining the defines. I'll need to update the viewer application to account for the breaking change and I'll want to change my .clang-format to use indention for the #defines but I'll check those in afterwards on my own I think. |
|
Oh you're right @jessey-git! I didn't modify the viewer application to support this modification. I focused on unit tests and validation tests only. I can check to integrate this into the same PR but I'm not super comfortable with Windows graphical API 😅 Anyway, if you want to pack all modifications (code + utests + viewer application), feel free to modify/reuse my proposal! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using unicode path under windows, there are some issues and files couldn't not be retrieved/accessed correctly. The way to fix this is to use filesystem::path to delegate path encoding to std library.