Removing un-needed packages #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has merge conflicts |
rogeliog
approved these changes
Mar 21, 2018
|
Just some merge conflicts... sorry for the long response |
SimenB
reviewed
Mar 22, 2018
package.json
Outdated
| "pify": "3.0.0", | ||
| "throat": "4.1.0", | ||
| "worker-farm": "1.5.0" | ||
| "jest-worker": "^21.2.1" |
There was a problem hiding this comment.
can you bump this to 22? I need jestjs/jest#5068 :P
SimenB
force-pushed
the
jgens/package-cleanup
branch
2 times, most recently
from
e9b31f2
to
dcd6421
Compare
|
Rebased this, and bumped to jest-worker@22 |
SimenB
reviewed
Mar 27, 2018
| @@ -2,8 +2,8 @@ | |||
|
|
|||
| exports[`Works when it has failing tests 1`] = ` | |||
| "FAIL integrationTests/__fixtures__/failing/__src__/file1.js | |||
| Company policies require ⚔️ 🏃 in every file | |||
There was a problem hiding this comment.
not sure about this one. Change in jest 22
There was a problem hiding this comment.
Not sure that I understand why that happened
There was a problem hiding this comment.
It's a deliberate change in jest 22
There was a problem hiding this comment.
Tracked this down, it's jestjs/jest#4504 (which was released in jest 21.2.0)
SimenB
force-pushed
the
jgens/package-cleanup
branch
2 times, most recently
from
d099239
to
4458f8c
Compare
Closed
SimenB
force-pushed
the
jgens/package-cleanup
branch
2 times, most recently
from
7e43e8f
to
74926fb
Compare
SimenB
force-pushed
the
jgens/package-cleanup
branch
from
74926fb
to
8fcb8e1
Compare
|
I've left jest at version 21 for the node 4 support. Can drop it in a separate PR if wanted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this package was significantly larger than I was expecting, and it seems like there's a bunch of prod dependencies that aren't needed. This just cleans them up.