fix: stop testing ESLint 5 (#893)

BREAKING CHANGE: Drop support for ESLint 5
jest-community · Sep 13, 2021 · 47a0138 · 47a0138
1 parent 13c041a
commit 47a0138
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml
@@ -68,7 +68,7 @@ jobs:
       fail-fast: false
       matrix:
         node-version: [12.x, 14.x, 16.x]
-        eslint-version: [5, 6, 7]
+        eslint-version: [6, 7]
     runs-on: ubuntu-latest
 
     steps:
@@ -83,12 +83,11 @@ jobs:
           yarn
           yarn add --dev eslint@${{ matrix.eslint-version }}
       - name: run tests
-        # only collect coverage on eslint versions that support the suggestions api
-        run: yarn test --coverage ${{ matrix.eslint-version >= 6 }}
+        run: yarn test --coverage
         env:
           CI: true
       - uses: codecov/codecov-action@v2.0.3
-        if: ${{ matrix.eslint-version >= 6 }}
+        if: always()
   test-os:
     name: Test on ${{ matrix.os }} using Node.js LTS
     needs: prepare-yarn-cache

diff --git a/package.json b/package.json
@@ -100,7 +100,7 @@
     "babel-jest": "^27.0.0",
     "babel-plugin-replace-ts-export-assignment": "^0.0.2",
     "dedent": "^0.7.0",
-    "eslint": "^5.1.0 || ^6.0.0 || ^7.0.0",
+    "eslint": "^6.0.0 || ^7.0.0",
     "eslint-config-prettier": "^6.5.0",
     "eslint-plugin-eslint-comments": "^3.1.2",
     "eslint-plugin-eslint-config": "^2.0.0",
@@ -123,7 +123,7 @@
   },
   "peerDependencies": {
     "@typescript-eslint/eslint-plugin": ">= 4",
-    "eslint": ">=5"
+    "eslint": ">=6"
   },
   "peerDependenciesMeta": {
     "@typescript-eslint/eslint-plugin": {

diff --git a/yarn.lock b/yarn.lock
@@ -4526,7 +4526,7 @@ __metadata:
     babel-jest: ^27.0.0
     babel-plugin-replace-ts-export-assignment: ^0.0.2
     dedent: ^0.7.0
-    eslint: ^5.1.0 || ^6.0.0 || ^7.0.0
+    eslint: ^6.0.0 || ^7.0.0
     eslint-config-prettier: ^6.5.0
     eslint-plugin-eslint-comments: ^3.1.2
     eslint-plugin-eslint-config: ^2.0.0
@@ -4548,7 +4548,7 @@ __metadata:
     typescript: ^4.4.0
   peerDependencies:
     "@typescript-eslint/eslint-plugin": ">= 4"
-    eslint: ">=5"
+    eslint: ">=6"
   peerDependenciesMeta:
     "@typescript-eslint/eslint-plugin":
       optional: true
@@ -4630,7 +4630,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"eslint@npm:^5.1.0 || ^6.0.0 || ^7.0.0":
+"eslint@npm:^6.0.0 || ^7.0.0":
   version: 7.32.0
   resolution: "eslint@npm:7.32.0"
   dependencies: