fix(prefer-to-contain): check that expect argument is defined before …

…use (#542) * fix(prefer-to-contain): check that expect argument is defined before use * chore: regenerate `yarn.lock`
jest-community · Mar 6, 2020 · 56f909b · 56f909b
1 parent c5d7d3b
commit 56f909b
Show file tree

Hide file tree

Showing 3 changed files with 530 additions and 412 deletions.
diff --git a/src/rules/__tests__/prefer-to-contain.test.ts b/src/rules/__tests__/prefer-to-contain.test.ts
@@ -5,6 +5,7 @@ const ruleTester = new TSESLint.RuleTester();
 
 ruleTester.run('prefer-to-contain', rule, {
   valid: [
+    'expect().toBe(false);',
     'expect(a).toContain(b);',
     "expect(a.name).toBe('b');",
     'expect(a).toBe(true);',

diff --git a/src/rules/prefer-to-contain.ts b/src/rules/prefer-to-contain.ts
@@ -187,6 +187,7 @@ export default createRule({
 
         if (
           !matcher ||
+          !includesCall ||
           (modifier && modifier.name !== ModifierName.not) ||
           !isBooleanEqualityMatcher(matcher) ||
           !isFixableIncludesCallExpression(includesCall)