fix(prefer-expect-assertions): properly handle checking across multip…

…le tests (#1089)
jest-community · Apr 22, 2022 · 8b61b0c · 8b61b0c
1 parent af2bdf9
commit 8b61b0c
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/src/rules/__tests__/prefer-expect-assertions.test.ts b/src/rules/__tests__/prefer-expect-assertions.test.ts
@@ -816,6 +816,20 @@ ruleTester.run('prefer-expect-assertions (callbacks)', rule, {
       `,
       options: [{ onlyFunctionsWithExpectInCallback: true }],
     },
+    {
+      code: dedent`
+        it('is a test', () => {
+          expect(expected).toBe(actual);
+        });
+
+        describe('my test', () => {
+          it('is another test', () => {
+            expect(expected).toBe(actual);
+          });
+        });
+      `,
+      options: [{ onlyFunctionsWithExpectInCallback: true }],
+    },
   ],
   invalid: [
     {

diff --git a/src/rules/prefer-expect-assertions.ts b/src/rules/prefer-expect-assertions.ts
@@ -178,6 +178,8 @@ export default createRule<[RuleOptions], MessageIds>({
           return;
         }
 
+        inTestCaseCall = false;
+
         if (node.arguments.length < 2) {
           return;
         }
-Original file line number
+Diff line change
@@ Expand Up / @@ -178,6 +178,8 @@ export default createRule<[RuleOptions], MessageIds>({ @@
               return;
             }
+            inTestCaseCall = false;
             if (node.arguments.length < 2) {
               return;
             }
@@ Expand Down @@