fix(expect-expect): don't error on it.todo & test.todo calls (#954)

jest-community · Oct 15, 2021 · d3cc0db · d3cc0db
1 parent 34cdbe0
commit d3cc0db
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/rules/__tests__/expect-expect.test.ts b/src/rules/__tests__/expect-expect.test.ts
@@ -15,6 +15,8 @@ const ruleTester = new TSESLint.RuleTester({
 
 ruleTester.run('expect-expect', rule, {
   valid: [
+    'it.todo("will test something eventually")',
+    'test.todo("will test something eventually")',
     "['x']();",
     'it("should pass", () => expect(true).toBeDefined())',
     'test("should pass", () => expect(true).toBeDefined())',

diff --git a/src/rules/expect-expect.ts b/src/rules/expect-expect.ts
@@ -11,6 +11,7 @@ import {
   createRule,
   getNodeName,
   getTestCallExpressionsFromDeclaredVariables,
+  isSupportedAccessor,
   isTestCaseCall,
 } from './utils';
 
@@ -116,6 +117,13 @@ export default createRule<
           isTestCaseCall(node) ||
           additionalTestBlockFunctions.includes(name)
         ) {
+          if (
+            node.callee.type === AST_NODE_TYPES.MemberExpression &&
+            isSupportedAccessor(node.callee.property, 'todo')
+          ) {
+            return;
+          }
+
           unchecked.push(node);
         } else if (matchesAssertFunctionName(name, assertFunctionNames)) {
           // Return early in case of nested `it` statements.