Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency eslint-plugin-eslint-plugin to v5 #1165

Merged
merged 2 commits into from
Jul 13, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 12, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint-plugin-eslint-plugin ^4.0.1 -> ^5.0.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox. ⚠ Warning: custom changes will be lost.

This PR has been generated by Mend Renovate. View repository job log here.

@G-Rath G-Rath merged commit cd25393 into main Jul 13, 2022
@G-Rath G-Rath deleted the renovate/eslint-plugin-eslint-plugin-5.x branch July 13, 2022 19:58
@@ -68,7 +68,9 @@ export default createRule<Options, MessageIds>({
name: __filename,
meta: {
messages: {
// eslint-disable-next-line eslint-plugin/no-unused-message-ids
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we report a bug?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Na these are being used by the base rule but we need to define them here to make TypeScript happy since it relates to what IDs we can use in the tests (they actually get overridden if the base rule exists).

I wouldn't expect the plugin to try and figure that out

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link

🎉 This PR is included in version 26.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants