Update eslint to the latest version 🚀 #125
Conversation
![greenkeeper[bot]](https://avatars.githubusercontent.com/in/505?s=60&v=4){kind=small}
|
@thymikee @rickhanlonii excellent opportunity to make some breaking changes 🙂 I think dropping node 4 and using APIs introduced in later eslints (like https://eslint.org/docs/developer-guide/working-with-rules#messageids) makes sense. We can then set the peer dep to whatever minor of elsint 4 that was introduced. But what about recommended rules. Thoughts on changing them? |
|
+1. Which rules could we adjust/add to recommended? I'm cool with being quite strict on that, to enforce vest practices, like short snapshots for example |
|
I'd like to add a rule for "no test description" and add to recommended (from this comment) |
|
yeah good idea. "no skipped tests" already has that, should be easy enough to extract to its own rule |
Version 5.0.1 just got published.Update to this version instead 🚀 Release Notesv5.0.1 |
|
Is there an ESLint v5 feature branch we can make PRs to? This is something I'm doing in eslint-plugin-promise with this v4 branch (v4 being the next major version of that plugin). I think it'd be great to track what we'd like in a major version release that targets ESLint v5, as I'd be happy to open a PR for refactoring to messageIds, for example. What are your thoughts/plans on coordinating multiple breaking changes in one go? |
|
I just set up a branch called |
Version 5.0.0 of eslint was just published.
[eslint](https://github.com/eslint/eslint)The version 5.0.0 is not covered by your current version range.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
It might be worth looking into these changes and trying to get this project onto the latest version of eslint.
If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.
Release Notes
v5.0.0Release blogpost
Migration guide
Commits
The new version differs by 148 commits.
36ced0a5.0.05fd5632Build: changelog update for 5.0.00feedfdNew: Added max-lines-per-function rule (fixes #9842) (#10188)daefbdbUpgrade: eslint-scope and espree to 4.0.0 (refs #10458) (#10500)077358bDocs: no-process-exit: recommend process.exitCode (#10478)f93d6ffFix: do not fail on unknown operators from custom parsers (fixes #10475) (#10476)05343fdFix: add parens for yield statement (fixes #10432) (#10468)d477c5eFix: check destructuring for "no-shadow-restricted-names" (fixes #10467) (#10470)7a7580bUpdate: Add considerPropertyDescriptor option to func-name-matching (#9078)e0a0418Fix: crash on optional catch binding (#10429)de4dba9Docs: styling team members (#10460)5e453a3Docs: display team members in tables. (#10433)b1895ebDocs: Restore intentional spelling mistake (#10459)a9da57d5.0.0-rc.03ac3df6Build: changelog update for 5.0.0-rc.0There are 148 commits in total.
See the full diff
FAQ and help
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper bot 🌴