fix: ensure rule fixes produce valid code when function params and args have trailing commas #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gs have trailing commas
SimenB
reviewed
Nov 11, 2022
| @@ -89,7 +107,7 @@ ruleTester.run('no-done-callback', rule, { | |||
| messageId: 'suggestWrappingInPromise', | |||
| data: { callback: 'done' }, | |||
| output: | |||
| 'test("something", () => {return new Promise((done) => {done();})})', | |||
| 'test("something", () => {return new Promise(done => {done();})})', | |||
There was a problem hiding this comment.
it should probably preserve the parens if they were there originally?
There was a problem hiding this comment.
Best practice for fixers are to avoid doing stylistic fixes since that should be enforced by another rule (which will be automatically fixed if possible), to help keep fixes as small as possible.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 24, 2022
## [27.1.6](v27.1.5...v27.1.6) (2022-11-24) ### Bug Fixes * ensure rule fixes produce valid code when function params and args have trailing commas ([#1282](#1282)) ([8eca0b7](8eca0b7))
|
🎉 This PR is included in version 27.1.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix that no one asked for 😄 props to @berkinanik for bring this to my attention over in
eslint-plugin-jest-dom.Weirdly ESLint doesn't seem to think some of the result syntax before this is invalid (namely in
no-done-callbackwhich'd give((), ) => {}), but didn't feel like digging into that further right now.