refactor: use Object.fromEntries to build rule config maps
#1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
approved these changes
Jan 3, 2023
There was a problem hiding this comment.
Sure, though I don't think it's worth marking it as a performance improvement unless you can actually show a clear speedup, since this is only done the first time the module is required and is for a relatively low number of files (which is why I didn't do this change in the first place)
|
I pretty much only chose "perf" because I couldn't think of a better label :) Happy to switch to "refactor" or anything else |
G-Rath
changed the title
Object.fromEntries to build rule config maps
|
🎉 This PR is included in version 27.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tiny change to use
Object.fromEntries(supported in Node 12+) instead of a.reduceloop.This improves performance a little by making it a O(n) instead of O(n^2) operation, since spreading the accumulator means creating a new object each iteration of the loop.