-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Jest and drop Node 4 #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean the runner will require jest 23?
@ljharb yes, which is needed for #43 EDIT: I misspoke; this does not actually do that, it's just dev dep. And I suppose the plugin can work with whatever version of jest, but the watchplugins wouldn't work for consumers unless they upgrade. However, we need the newest |
@ljharb, it is just a |
I guess it is fine to drop Node 4 now that its end of life has come https://github.com/nodejs/Release cc: @ljharb |
A node version being EOL means you could drop it; in no way does it mean one should. However, jest’s aggressive dropping of node versions might force our hand, as a jest plugin. |
@ljharb I agree 😄 ! As you mentioned, I meant this in the context of Jest already not supporting Node 4 jestjs/jest#4769 |
No description provided.