Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Jest and drop Node 4 #48

Merged
merged 5 commits into from
Sep 26, 2018
Merged

Upgrade Jest and drop Node 4 #48

merged 5 commits into from
Sep 26, 2018

Conversation

rogeliog
Copy link
Member

No description provided.

Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean the runner will require jest 23?

@SimenB
Copy link
Member

SimenB commented Sep 23, 2018

@ljharb yes, which is needed for #43

EDIT: I misspoke; this does not actually do that, it's just dev dep. And I suppose the plugin can work with whatever version of jest, but the watchplugins wouldn't work for consumers unless they upgrade.

However, we need the newest create-jest-runner for #43, and that requires Node 6. So it's a breaking change in that regard

@rogeliog
Copy link
Member Author

@ljharb, it is just a devDepencency so it is just the version of Jest used to test this runner.

@rogeliog
Copy link
Member Author

rogeliog commented Sep 26, 2018

I guess it is fine to drop Node 4 now that its end of life has come https://github.com/nodejs/Release cc: @ljharb

@rogeliog rogeliog changed the title Upgrade Jest Upgrade Jest and drop Node 4 Sep 26, 2018
.travis.yml Show resolved Hide resolved
@ljharb
Copy link
Collaborator

ljharb commented Sep 26, 2018

A node version being EOL means you could drop it; in no way does it mean one should.

However, jest’s aggressive dropping of node versions might force our hand, as a jest plugin.

@rogeliog
Copy link
Member Author

@ljharb I agree 😄 ! As you mentioned, I meant this in the context of Jest already not supporting Node 4 jestjs/jest#4769

@rogeliog rogeliog merged commit db664b6 into master Sep 26, 2018
@rogeliog rogeliog deleted the upgrade-jest branch September 26, 2018 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants