updated linting and jest test

jestjs · Dec 19, 2017 · 5379f7f · 5379f7f
1 parent dbb1363
commit 5379f7f
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 9 deletions.
diff --git a/integration_tests/__tests__/__snapshots__/show_config.test.js.snap b/integration_tests/__tests__/__snapshots__/show_config.test.js.snap
@@ -77,7 +77,7 @@ exports[`--showConfig outputs config info and exits 1`] = `
     \\"maxWorkers\\": \\"[maxWorkers]\\",
     \\"noStackTrace\\": false,
     \\"nonFlagArgs\\": [],
-    \\"notify\\": false,
+    \\"notify\\": \\"false\\",
     \\"passWithNoTests\\": false,
     \\"rootDir\\": \\"<<REPLACED_ROOT_DIR>>\\",
     \\"runTestsByPath\\": false,

diff --git a/packages/jest-cli/src/reporters/notify_reporter.js b/packages/jest-cli/src/reporters/notify_reporter.js
@@ -37,15 +37,22 @@ export default class NotifyReporter extends BaseReporter {
     const success =
       result.numFailedTests === 0 && result.numRuntimeErrorTestSuites === 0;
 
-    if (success && (this._globalConfig.notify === "true" || this._globalConfig.notify === "onSuccess")) {
+    if (
+      success &&
+      (this._globalConfig.notify === 'true' ||
+        this._globalConfig.notify === 'onSuccess')
+    ) {
       const title = util.format('%d%% Passed', 100);
       const message = util.format(
         (isDarwin ? '\u2705 ' : '') + '%d tests passed',
         result.numPassedTests,
       );
 
       notifier.notify({icon, message, title});
-    } else if (this._globalConfig.notify === "true" || this._globalConfig.notify === "onFailure") {
+    } else if (
+      this._globalConfig.notify === 'true' ||
+      this._globalConfig.notify === 'onFailure'
+    ) {
       const failed = result.numFailedTests / result.numTotalTests;
 
       const title = util.format(

diff --git a/packages/jest-cli/src/test_scheduler.js b/packages/jest-cli/src/test_scheduler.js
@@ -254,7 +254,7 @@ export default class TestScheduler {
       this.addReporter(new CoverageReporter(this._globalConfig));
     }
 
-    if (notify !== "false") {
+    if (notify !== 'false') {
       this.addReporter(
         new NotifyReporter(this._globalConfig, this._options.startRun),
       );

diff --git a/packages/jest-config/src/defaults.js b/packages/jest-config/src/defaults.js
@@ -50,7 +50,7 @@ export default ({
   moduleNameMapper: {},
   modulePathIgnorePatterns: [],
   noStackTrace: false,
-  notify: "false",
+  notify: 'false',
   preset: null,
   resetMocks: false,
   resetModules: false,

diff --git a/packages/jest-config/src/valid_config.js b/packages/jest-config/src/valid_config.js
@@ -57,7 +57,7 @@ export default ({
   modulePaths: ['/shared/vendor/modules'],
   name: 'string',
   noStackTrace: false,
-  notify: "false",
+  notify: 'false',
   onlyChanged: false,
   preset: 'react-native',
   projects: ['project-a', 'project-b/'],

diff --git a/packages/jest-validate/src/__tests__/fixtures/jest_config.js b/packages/jest-validate/src/__tests__/fixtures/jest_config.js
@@ -38,7 +38,7 @@ const defaultConfig = {
   moduleNameMapper: {},
   modulePathIgnorePatterns: [],
   noStackTrace: false,
-  notify: "false",
+  notify: 'false',
   preset: null,
   resetMocks: false,
   resetModules: false,
@@ -94,7 +94,7 @@ const validConfig = {
   modulePaths: ['/shared/vendor/modules'],
   name: 'string',
   noStackTrace: false,
-  notify: "false",
+  notify: 'false',
   preset: 'react-native',
   resetMocks: false,
   resetModules: false,

diff --git a/test_utils.js b/test_utils.js
@@ -36,7 +36,7 @@ const DEFAULT_GLOBAL_CONFIG: GlobalConfig = {
   noSCM: null,
   noStackTrace: false,
   nonFlagArgs: [],
-  notify: "false",
+  notify: 'false',
   onlyChanged: false,
   onlyFailures: false,
   outputFile: null,