Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spyOn property with accessType does not work for instances of a Class #5746

Closed
nc-lot opened this issue Mar 7, 2018 · 5 comments
Closed

Comments

@nc-lot
Copy link

nc-lot commented Mar 7, 2018

Do you want to request a feature or report a bug?
Feature for spyOn to work with objects that have getters/setters on the prototype chain.

What is the current behavior?
Does not support spying on getters/setters on the object's prototype chain.

If the current behavior is a bug, please provide the steps to reproduce and
either a repl.it demo through https://repl.it/languages/jest or a minimal
repository on GitHub that we can yarn install and yarn test.

I have recreated this issue in this repl.
https://repl.it/@functionator/spyOn-getter

What is the expected behavior?
Should be able mock getters/setters on the object's prototype chain.

Please provide your exact Jest configuration and mention your Jest, node,
yarn/npm version and operating system.

jest: v22.1.0
npm: 5.6.0
node: v9.3.0
os: Mac High Sierra v10.13.3
@SimenB
Copy link
Member

SimenB commented Mar 7, 2018

@phra ideas?

@phra
Copy link
Contributor

phra commented Mar 7, 2018

@nc-lot thanks for the report.

@SimenB i'll have a look later or tomorrow.

@nc-lot
Copy link
Author

nc-lot commented Mar 7, 2018

If you guys don't mind, can I take a stab at this tonight? I'll be using my personal account @thomasjinlo

@nc-lot nc-lot changed the title spyOn property with accessType not working as expected spyOn property with accessType does not work for instances of a Class Mar 7, 2018
thomasjinlo added a commit to thomasjinlo/jest that referenced this issue Mar 8, 2018
thomasjinlo added a commit to thomasjinlo/jest that referenced this issue Mar 8, 2018
thomasjinlo added a commit to thomasjinlo/jest that referenced this issue Mar 9, 2018
@cpojer cpojer closed this as completed in 4034718 Mar 11, 2018
@phra
Copy link
Contributor

phra commented May 2, 2018

@cpojer can't 4034718 be cherrypicked and shipped as a patch on branch 22.x?

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants