-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fake timers with a delay of NaN never get run #5960
Comments
Nice catch! Should be easy enough to fix, just need to expand handling here: https://github.com/facebook/jest/blob/1a51672c7597d900953a0b95e4430e65eaa04259/packages/jest-util/src/fake_timers.js#L489-L491 |
Shouldn't this issue be closed if #5966 was merged? |
Indeed! |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Do you want to request a feature or report a bug?
Bug
What is the current behavior?
Timers with a timeout of
NaN
can never get run when fake timers are in use.If the current behavior is a bug, please provide the steps to reproduce and
either a repl.it demo through https://repl.it/languages/jest or a minimal
repository on GitHub that we can
yarn install
andyarn test
.https://repl.it/repls/MedicalSolidLines
What is the expected behavior?
setTimeout(callback, NaN)
is treated the same assetTimeout(callback, 0)
when fake timers are in use. This matches the behavior specified by the HTML Living Standard.https://html.spec.whatwg.org/multipage/webappapis.html#windoworworkerglobalscope-mixin:dom-settimeout
https://heycam.github.io/webidl/#abstract-opdef-converttoint
The text was updated successfully, but these errors were encountered: