Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Node 10.5.0 test failures #6529

Closed
SimenB opened this issue Jun 23, 2018 · 2 comments · Fixed by #6532
Closed

Investigate Node 10.5.0 test failures #6529

SimenB opened this issue Jun 23, 2018 · 2 comments · Fixed by #6532

Comments

@SimenB
Copy link
Member

SimenB commented Jun 23, 2018

The spec packages/jest-runtime/src/__tests__/script_transformer.test.js fails on node 10.5.0, while it passes on node 10.4.1 (and node 6, 8 & 9).

Skipping a single test doesn't matter, it'll fail the top one either way.

  ● ScriptTransformer › does not transform Node core modules

    TypeError: Cannot read property 'prototype' of undefined

      at patch (node_modules/graceful-fs/graceful-fs.js:166:54)

  ● ScriptTransformer › does not transform Node core modules

    TypeError: ScriptTransformer is not a constructor

      at Object.it (packages/jest-runtime/src/__tests__/script_transformer.test.js:227:31)

I'm opening the issue here instead of node/graceful-fs since we do a lot of mocking fs in that test.

https://github.com/facebook/jest/blob/404da0f53bd9c6204823e4ce96c1b6742e7470e3/packages/jest-runtime/src/__tests__/script_transformer.test.js

@thymikee @rickhanlonii ideas? I haven't dug into it

@thymikee
Copy link
Collaborator

Had a look yesterday but no luck. Tried to come up with minimal repro but didn't succeed. Maybe it's something connected to VM

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants