Update Docusaurus to 1.3.0

[yangshun]

Summary

Docusuarus 1.3.0 brings about some backwards-incompatible CSS changes. So the team is helping the major users update 😄

Thankfully Jest doesn't have much custom CSS, so there isn't too much to be done.

Changes made:

• Upgraded Docusaurus - CSS changes
• The landing page logo was invisible to the user because it was a white-outline logo on a white background. Changed it to the non-outline version.
• Changed the theme of the syntax highlighting to a "ocean". It has more contrast and looks better. Hopefully it's welcome. If not I'd be glad to revert it.
• Enabled in-page navigation in siteConfig.js for better user experience while browsing the docs.

Test plan

Ran the site locally and visited every page.

[SimenB]

yarn lint --fix from the root of the project (not the website directory) should fix it 🙂

[SimenB]

Mind including the yarn.lock changes?

[SimenB]

I love the new theme and navbar, btw!

[yangshun]

Oh I forgot about yarn.lock. Will update

…

On Wed, Jun 20, 2018, 10:50 PM Simen Bekkhus ***@***.***> wrote: I love the new theme and navbar, btw! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6510 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQRHRxd1gDe77mR4unWFnYAZ6CHgNeMks5t-zQSgaJpZM4UxZAN> .

[thymikee]

Not sure about the color theme changes. What I'm concerned is that the dark background of the code on white website seems to me like it's "popping out", and kinda distracts me when I change focus from one code block to another.

[thymikee]

To fix this, we could make the code background opaque a bit (just less contrasting to the website bg), just not sure how if the code will still be readable though.

[yangshun]

Hmm got it @thymikee. Do you want me to revert the code background theme? Alternatively, pick another theme from https://github.com/isagalaev/highlight.js/tree/master/src/styles 😄

[thymikee]

Not quite revert, because I like that the new theme is better at syntax coloring :D. Would be nice to tweak it a bit.

[cpojer]

Can we use a light syntax team please?

[yangshun]

I shall leave the theme as it is. Would be better not to include them in this PR 😄

[endiliey]

Excited to see this update 😊. Pretty url ? (No .html) ?

[yangshun]

@endiliey Thanks for the reminder, I turned on the cleanUrl option. @SimenB this is ready to be reviewed again.

[yangshun]

Are the CI failures legit? They don't seem related.

[SimenB]

Not sure about the CI failures... Doesn't seem related

[SimenB]

Opened up #6529 tracking CI failures

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.