Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop printing the same error for each individual test caused by beforeAll when it fails #10004

Closed
wants to merge 2 commits into from
Closed

fix: stop printing the same error for each individual test caused by beforeAll when it fails #10004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7923397
fix: stop printing the same error for individual tests when beforeAll…
vldmrkl May 8, 2020
c3b5fac
update changelog
vldmrkl May 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

- `[jest-jasmine2]` Stop adding `:` after an error that has no message ([#9990](https://github.com/facebook/jest/pull/9990))
- `[jest-diff]` Control no diff message color with `commonColor` in diff options ([#9997](https://github.com/facebook/jest/pull/9997))
- `[jest-circus]` Stop printing errors for individual tests when beforeAll fails ([#10004](https://github.com/facebook/jest/pull/10004))

### Chore & Maintenance

Expand Down
8 changes: 1 addition & 7 deletions packages/jest-circus/src/eventHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import type {Circus} from '@jest/types';
import {TEST_TIMEOUT_SYMBOL} from './types';

import {
addErrorToEachTestUnderDescribe,
describeBlockHasTests,
getTestDuration,
invariant,
Expand Down Expand Up @@ -154,13 +153,8 @@ const eventHandler: Circus.EventHandler = (
case 'hook_failure': {
const {test, describeBlock, error, hook} = event;
const {asyncError, type} = hook;

if (type === 'beforeAll') {
if (type === 'beforeAll' || type === 'afterAll') {
invariant(describeBlock, 'always present for `*All` hooks');
addErrorToEachTestUnderDescribe(describeBlock, error, asyncError);
} else if (type === 'afterAll') {
// Attaching `afterAll` errors to each test makes execution flow
// too complicated, so we'll consider them to be global.
state.unhandledErrors.push([error, asyncError]);
} else {
invariant(test, 'always present for `*Each` hooks');
Expand Down