Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip ELDHISTOGRAM for --detectOpenHandles #10417

Merged
merged 6 commits into from
Aug 19, 2020
Merged

fix: skip ELDHISTOGRAM for --detectOpenHandles #10417

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9cee325
fix: skip open handle
Aug 17, 2020
079272d
Update CHANGELOG.md
Aug 17, 2020
6564528
fix: don't report ELD histograms as open handles
Aug 17, 2020
5f86e41
Add histogram object
Aug 18, 2020
976894c
Update test with onNodeVersions
Aug 19, 2020
d009d97
Merge branch 'master' into skip-eldhistogram-handle
SimenB Aug 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/jest-core/src/collectHandles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,11 @@ export default function collectHandles(): () => Array<Error> {
_triggerAsyncId,
resource: {} | NodeJS.Timeout,
) {
if (type === 'PROMISE' || type === 'TIMERWRAP') {
if (
type === 'PROMISE' ||
type === 'TIMERWRAP' ||
type === 'ELDHISTOGRAM'
SimenB marked this conversation as resolved.
Show resolved Hide resolved
) {
return;
}
const error = new ErrorWithStack(type, initHook);
Expand Down