Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add missing "--roots" options #10793

Merged
merged 1 commit into from
Nov 9, 2020
Merged

docs: add missing "--roots" options #10793

merged 1 commit into from
Nov 9, 2020

Conversation

vbabak
Copy link
Contributor

@vbabak vbabak commented Nov 7, 2020 •
edited by SimenB
Loading

Summary

Fixes #10760

Test plan

@facebook-github-bot
Copy link
Contributor

Hi @vbabak!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@vbabak vbabak closed this Nov 7, 2020
@vbabak vbabak reopened this Nov 7, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@vbabak vbabak mentioned this pull request Nov 7, 2020
Closed
SimenB
SimenB approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB changed the title docs: add missing "--roots" options #10760 docs: add missing "--roots" options Nov 9, 2020
@SimenB SimenB merged commit 01f29e3 into jestjs:master Nov 9, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

jeysal added a commit to mmkal/jest that referenced this pull request Nov 10, 2020
@jeysal
Merge branch 'master' into uglier-inline-snapshots
be68e58 
* master:
  chore(docs): update TutorialReactNative.md (jestjs#10802)
  fix: console dir should respect options (jestjs#10638)
  docs: add missing "--roots" options (jestjs#10793)
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--roots option is missing in the docs
3 participants
@vbabak @facebook-github-bot @SimenB