Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move from source-map to source-map-sync #11070

Closed
wants to merge 2 commits into from
Closed

Conversation

7rulnik
Copy link

@7rulnik 7rulnik commented Feb 9, 2021

Summary

I made the fork of source-map that introduces sync API, but still uses WASM.
You can compare changes to original versions here

Test plan

source-map-sync uses the same unit test as the original source-map, but not sure that enough

@7rulnik 7rulnik changed the title move from source-map to source-map-js move from source-map to source-map-sync Feb 15, 2021
@codecov-io
Copy link

Codecov Report

Merging #11070 (740ad9f) into master (e11072b) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11070      +/-   ##
==========================================
- Coverage   64.22%   64.21%   -0.01%     
==========================================
  Files         305      305              
  Lines       13255    13257       +2     
  Branches     3235     3236       +1     
==========================================
  Hits         8513     8513              
- Misses       4050     4051       +1     
- Partials      692      693       +1     
Impacted Files Coverage Δ
packages/jest-jasmine2/src/jasmine/Spec.ts 0.00% <ø> (ø)
packages/jest-jasmine2/src/reporter.ts 56.81% <0.00%> (-1.33%) ⬇️
packages/jest-reporters/src/CoverageReporter.ts 57.23% <ø> (ø)
packages/jest-source-map/src/getCallsite.ts 71.42% <0.00%> (-3.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e11072b...740ad9f. Read the comment docs.

@7rulnik
Copy link
Author

7rulnik commented Feb 15, 2021

Seems that CI failed on master too

@onigoetz
Copy link

onigoetz commented Jan 9, 2022

Hi, @SimenB I'd be interested in this PR to land.

Is there anything I can help with to get this rolling ?

@TrySound
Copy link
Contributor

TrySound commented Jan 9, 2022

The package now called source-map-js. @7rulnik could you update this pr when you back?

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

This PR is stale because it has been open 1 year with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Jan 9, 2023
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

This PR was closed because it has been stalled for 30 days with no activity. Please open a new PR if the issue is still relevant, linking to this one.

@github-actions github-actions bot closed this Feb 8, 2023
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants