Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: minor simplify format results error #11432

Merged
merged 3 commits into from
May 21, 2021
Merged

chore: minor simplify format results error #11432

merged 3 commits into from
May 21, 2021

Conversation

Connormiha
Copy link
Contributor

@Connormiha Connormiha commented May 20, 2021 •
edited
Loading

Summary

Removed needless .map call.

SimenB
SimenB approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

SimenB
SimenB reviewed May 20, 2021
View reviewed changes
packages/jest-message-util/src/index.ts Outdated
result.failureMessages
.map(checkForCommonEnvironmentErrors)
.forEach(content => errors.push({content, result}));
result.failureMessages.forEach((item: string) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the explicit type annotation needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter warned about implicit any type

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I'm not seeing any error, let's try without

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2021 •
edited
Loading

Codecov Report

Merging #11432 (036a6f0) into master (50451df) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11432      +/-   ##
==========================================
- Coverage   69.27%   69.26%   -0.01%     
==========================================
  Files         311      311              
  Lines       16272    16272              
  Branches     4701     4701              
==========================================
- Hits        11272    11271       -1     
- Misses       4972     4973       +1     
  Partials       28       28
Impacted Files Coverage Δ
packages/jest-message-util/src/index.ts 85.95% <100.00%> (ø)
packages/expect/src/utils.ts 95.58% <0.00%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50451df...036a6f0. Read the comment docs.

@SimenB SimenB changed the title Minor simplify format results error chore: minor simplify format results error May 21, 2021
@SimenB SimenB merged commit 2226742 into jestjs:master May 21, 2021
@SimenB
Copy link
Member

SimenB commented May 21, 2021

Thanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Connormiha @codecov-commenter @SimenB @facebook-github-bot