fix(eslint): use eslint-import-resolver-typescript to fix import/no-unresolved #12016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
reviewed
Nov 29, 2021
| @@ -10,17 +10,19 @@ import dns from 'dns'; | |||
| // eslint-disable-next-line no-restricted-imports | |||
| import {readFileSync} from 'fs'; | |||
| import {createRequire} from 'module'; | |||
| import prefixDns from 'node:dns'; | |||
There was a problem hiding this comment.
I assume this is due to #12007 - can you just roll back the change CI is unhappy about?
chentsulin
force-pushed
the
fix-no-unresolved
branch
from
5f84fc0 to
cdaa0c3
Compare
Codecov Report
@@ Coverage Diff @@
## main #12016 +/- ##
=======================================
Coverage 68.90% 68.90%
=======================================
Files 324 324
Lines 16681 16681
Branches 4814 4814
=======================================
Hits 11494 11494
Misses 5154 5154
Partials 33 33 Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#12011
In the TypeScript section of
eslint-plugin-import's README, they say "You will also need to install and configure the TypeScript resolver: eslint-import-resolver-typescript."It uses
pathsdefined intsconfig.jsonto help resolving the packages.Test plan
yarn linton my machine returns no errors.