jest-worker: Unable to customize thread execArgv with enableThreadWorkers

[kherock]

Summary

Currently it's impossible to pass custom execArgv to a worker when enableWorkerThreads is on.

Test plan

The existing tests were enforcing less than ideal behavior, I've updated them to pass forkOptions as top-level properties to the worker constructor. worker_threads doesn't have cwd or execPath equivalents so I've dropped those properties from the tests.

[facebook-github-bot]

Hi @kherock!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[SimenB]

Thanks for the PR @kherock! Could you add some details about what this change fixes? I see the unit test is updated, but that only asserts on what is passed, not really how it behaves

[kherock]

Sure, before it was passing everything in the worker data payload instead of as spawn options for the thread. This made it impossible to directly set things like execArgv and env for the thread so that loader hooks such as ts-node's or Yarn's PnP can function.

[SimenB]

Yeah, I looked through the docs, this seems correct 👍

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.