-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update pirates
to 4.0.4
#12136
fix: update pirates
to 4.0.4
#12136
Conversation
Related to issue [#75](danez/pirates#75) ``` Cannot find module '/Users/Ritchie/Developer/@fastcms/fastcms/node_modules/.pnpm/@jest+transform@27.4.2/node_modules/pirates/lib/index.js'. Please verify that the package.json has a valid "main" entry ```
Hi @laozhu! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @laozhu, and thanks for the PR! Could you sign the CLA and run yarn (plus update the changelog)?
Ping @laozhu |
Sorry, I forgot this issue, will deal with this pr tonight 😄 |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Codecov Report
@@ Coverage Diff @@
## main #12136 +/- ##
=======================================
Coverage 67.71% 67.71%
=======================================
Files 328 328
Lines 16991 16991
Branches 4817 4817
=======================================
Hits 11506 11506
Misses 5452 5452
Partials 33 33 Continue to review full report at Codecov.
|
pirates
to 4.0.4
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Related to issue #75