Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(GettingStarted): separate TypeScript sections #12306

Merged
merged 4 commits into from
Feb 7, 2022
Merged

docs(GettingStarted): separate TypeScript sections #12306

merged 4 commits into from
Feb 7, 2022

Conversation

Biki-das
Copy link
Contributor

@Biki-das Biki-das commented Feb 6, 2022

this adds a seperate section for typescript usage.

@codecov-commenter
Copy link

Codecov Report

Merging #12306 (21f1563) into main (4f4be57) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12306   +/-   ##
=======================================
  Coverage   67.52%   67.53%           
=======================================
  Files         328      328           
  Lines       17244    17244           
  Branches     5069     5069           
=======================================
+ Hits        11644    11645    +1     
+ Misses       5567     5566    -1     
  Partials       33       33           
Impacted Files Coverage Δ
packages/expect/src/utils.ts 96.53% <0.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f4be57...21f1563. Read the comment docs.

@Biki-das
Copy link
Contributor Author

Biki-das commented Feb 7, 2022

@SimenB ping

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call! just left a tiny nit

docs/GettingStarted.md Outdated Show resolved Hide resolved
@Biki-das Biki-das requested a review from SimenB February 7, 2022 14:23
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! could you update the new 27.5 docs as well?

@Biki-das
Copy link
Contributor Author

Biki-das commented Feb 7, 2022

thanks! could you update the new 27.5 docs as well?

sure

@Biki-das Biki-das requested a review from SimenB February 7, 2022 14:41
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB changed the title Chore: doc(GettingStarted): separate TypeScript sections docs(GettingStarted): separate TypeScript sections Feb 7, 2022
@SimenB SimenB merged commit 7aadc37 into jestjs:main Feb 7, 2022
@Biki-das Biki-das deleted the doc-jest branch February 7, 2022 14:44
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants