Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(jest-serializer): remove unnecessary ambient type module #12360

Merged
merged 1 commit into from
Feb 10, 2022
Merged

refactor(jest-serializer): remove unnecessary ambient type module #12360

merged 1 commit into from
Feb 10, 2022

Conversation

mrazauskas
Copy link
Contributor

Summary

While looking at coverage report, my eye spotted v8.d.ts file in jest-serializer. Seems like it doesn’t do much anymore. Not important at all, just couldn’t leave it.

Test plan

Green CI.

@codecov-commenter
Copy link

Codecov Report

Merging #12360 (1d08389) into main (ff7a751) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12360   +/-   ##
=======================================
  Coverage   66.91%   66.91%           
=======================================
  Files         329      329           
  Lines       17353    17353           
  Branches     5058     5058           
=======================================
  Hits        11612    11612           
  Misses       5709     5709           
  Partials       32       32           
Impacted Files Coverage Δ
packages/jest-serializer/src/index.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff7a751...1d08389. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I think v8 was just missing from @types/node or something at the time 👍

@SimenB SimenB merged commit 0c455a9 into jestjs:main Feb 10, 2022
@mrazauskas mrazauskas deleted the serializer-clean-up branch February 10, 2022 14:39
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants